Skip to content

feat: replace buttons with links in samples index and description pages #2603

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

feat: replace buttons with links in samples index and description pages #2603

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions web/samples_index/lib/src/templates.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,14 +133,14 @@ String _backgroundImage(String url) =>
String _indexCards(List<Sample> samples) => samples.map(_indexCard).join();
String _indexCard(Sample sample) => '''
<div class="mdc-card demo-card mdc-elevation--z0" search-attrs="${_escapeAttribute(sample.searchAttributes)}">
<div class="mdc-card__primary-action demo-card__primary-action" tabindex="0" href="${sample.filename}.html">
<a class="mdc-card__primary-action demo-card__primary-action" href="${sample.filename}.html">
<div class="mdc-card__media mdc-card__media--16-9 demo-card__media" style="${_backgroundImage(sample.thumbnail)}"></div>
<div class="demo-card__label type-label">${_escapeElement(sample.type)}</div>
<div class="demo-card__primary">
<h2 class="demo-card__title mdc-typography mdc-typography--headline6">${_escapeElement(sample.name)}</h2>
</div>
<div class="demo-card__secondary mdc-typography mdc-typography--body2">${sample.shortDescription}</div>
</div>
</a>
</div>
''';

Expand Down Expand Up @@ -186,18 +186,18 @@ String _descriptionButtons(Sample sample) {
var sampleLink = sample.web;
if (sampleLink != null && sampleLink.isNotEmpty) {
buf.write(
'''<button class="mdc-button mdc-button--outlined" onclick="window.location.href = '$sampleLink';"><span class="mdc-button__ripple"></span> Launch App</button>''');
'''<a class="mdc-button mdc-button--outlined" href=$sampleLink><span class="mdc-button__ripple"></span> Launch App</a>''');
}

if (sample.type == 'app' ||
sample.type == 'sample' ||
sample.type == 'demo') {
buf.write(
'''<button class="mdc-button mdc-button--outlined" onclick="window.location.href = '${sample.source}';">
'''<a class="mdc-button mdc-button--outlined" href="${sample.source}">
<div class="mdc-button__ripple"></div>
<i class="material-icons mdc-button__icon" aria-hidden="true">code</i>
<span class="mdc-button__label">Source Code</span>
</button>''');
</a>''');
}
return buf.toString();
}
Expand Down
7 changes: 1 addition & 6 deletions web/samples_index/web/main.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,12 +31,7 @@ void main() {
filterCards();
});

// Use a ripple effect on all cards
querySelectorAll('.mdc-card__primary-action').forEach((el) => MDCRipple(el)
// Navigate to the description page when tapped
..listen('click', (e) {
window.location.href = el.attributes['href']!;
}));
querySelectorAll('.mdc-card__primary-action').forEach((el) => MDCRipple(el));

// Filter cards on each keypress
searchBar.listen('keydown', (e) async {
Expand Down
8 changes: 3 additions & 5 deletions web/samples_index/web/styles.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -226,11 +226,9 @@ a {
flex-direction: column;
}

.buttons {
button {
margin-right: 12px;
margin-bottom: 8px;
}
.buttons a {
margin-right: 12px;
margin-bottom: 8px;
}
}

Expand Down