Skip to content

Conversation

@ericwindmill
Copy link
Contributor

@ericwindmill ericwindmill commented Dec 5, 2024

Description of what this PR is changing or adding, and why:

This PR adds an 'index' page for the Design Pattern cookbook recipes under App Architecture in the side nav.

  • Adds the page
  • Adds a design-pattern.yml file with
  • Adds an "Expansion Panel List" component (html + css)

This is still very much a work in progress. Before merging:

Issues fixed by this PR (if any):

@ericwindmill
Copy link
Contributor Author

ericwindmill commented Dec 5, 2024

@parlough I've made this PR before it's complete because I'm hoping you can review the SCSS updates I made. Also, I'm generally curious how you feel about adding a component like this. I think something like this will be useful for FWE.

I reused the logic from the sidenav for expanding the panels. But the panels I added have bad jank that I can't figure out.
edit: nevermind I figured it out. I'll update the PR in bit.

@flutter-website-bot
Copy link
Collaborator

flutter-website-bot commented Dec 5, 2024

Visit the preview URL for this PR (updated for commit 7313cb4):

https://flutter-docs-prod--pr11468-design-pattern-index-cyxammgk.web.app

@@ -0,0 +1,3 @@
{
"tags": "design-patterns"
}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add tags to be used in collections all to all files in this directory

@ericwindmill ericwindmill marked this pull request as ready for review December 9, 2024 15:41
@ericwindmill ericwindmill requested review from a team and sfshaza2 as code owners December 9, 2024 15:41
@ericwindmill ericwindmill requested a review from parlough December 9, 2024 15:42
@parlough parlough self-assigned this Dec 9, 2024
Copy link
Contributor

@sfshaza2 sfshaza2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If @parlough is happy, then I'm happy. And it seems like he approves (based on the thumbs up and heart emojis). lgtm, but I will let you land, when ready.

Copy link
Member

@parlough parlough left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ericwindmill! This is super cool. I pushed a few minor css changes, particularly to improve the focus outline. Most changes have a comment with more info.

I do wonder if these should just be in a /app-architecture/design-patterns/ directory though and not called recipes?

@ericwindmill
Copy link
Contributor Author

ericwindmill commented Dec 11, 2024

I do wonder if these should just be in a /app-architecture/design-patterns/ directory though and not called recipes?

I agree, and I moved them.
I also moved the code examples, which is why there are many more files changed in the PR

@ericwindmill ericwindmill merged commit ddb7979 into main Dec 11, 2024
9 checks passed
@ericwindmill ericwindmill deleted the design-pattern-index branch December 11, 2024 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

☂ Land updated app architecture guidance

4 participants