-
Notifications
You must be signed in to change notification settings - Fork 3.4k
Design pattern index page #11468
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Design pattern index page #11468
Conversation
|
@parlough I've made this PR before it's complete because I'm hoping you can review the SCSS updates I made. Also, I'm generally curious how you feel about adding a component like this. I think something like this will be useful for FWE. I reused the logic from the sidenav for expanding the panels. But the panels I added have bad jank that I can't figure out. |
|
Visit the preview URL for this PR (updated for commit 7313cb4): https://flutter-docs-prod--pr11468-design-pattern-index-cyxammgk.web.app |
src/content/assets/images/docs/app-architecture/design-patterns/sql-icon.svg
Show resolved
Hide resolved
…-pattern-index
…site into design-pattern-index
| @@ -0,0 +1,3 @@ | |||
| { | |||
| "tags": "design-patterns" | |||
| } | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add tags to be used in collections all to all files in this directory
remove unneeded whitespace
sfshaza2
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If @parlough is happy, then I'm happy. And it seems like he approves (based on the thumbs up and heart emojis). lgtm, but I will let you land, when ready.
parlough
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @ericwindmill! This is super cool. I pushed a few minor css changes, particularly to improve the focus outline. Most changes have a comment with more info.
I do wonder if these should just be in a /app-architecture/design-patterns/ directory though and not called recipes?
I agree, and I moved them. |
Description of what this PR is changing or adding, and why:
This PR adds an 'index' page for the Design Pattern cookbook recipes under App Architecture in the side nav.
design-pattern.ymlfile withThis is still very much a work in progress. Before merging:
design-pattern.ymlwith real dataIssues fixed by this PR (if any):