Skip to content

Add breaking change doc for isFocusable #12159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add breaking change doc for isFocusable #12159

wants to merge 2 commits into from

Conversation

hannah-hyj
Copy link
Member

Description of what this PR is changing or adding, and why:

Issues fixed by this PR (if any):

PRs or commits this PR depends on (if any):

Presubmit checklist

  • This PR is marked as draft with an explanation if not meant to land until a future stable release.
  • This PR doesn’t contain automatically generated corrections (Grammarly or similar).
  • This PR follows the Google Developer Documentation Style Guidelines — for example, it doesn’t use i.e. or e.g., and it avoids I and we (first person).
  • This PR uses semantic line breaks of 80 characters or fewer.

@hannah-hyj hannah-hyj requested review from sfshaza2, antfitch, parlough and a team as code owners June 27, 2025 20:43
@hannah-hyj hannah-hyj mentioned this pull request Jun 27, 2025
Merged
9 tasks
@flutter-website-bot
Copy link
Collaborator

flutter-website-bot commented Jun 27, 2025 •
edited
Loading

Visit the preview URL for this PR (updated for commit a7fa637):

https://flutter-docs-prod--pr12159-focusable-d7a754zs.web.app

sfshaza2
sfshaza2 reviewed Jun 27, 2025
View reviewed changes
Copy link
Contributor

@sfshaza2 sfshaza2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few minor updates and one question.

src/content/release/breaking-changes/deprecate-focusable.md

Landed in version: Not yet<br>
In stable release: Not yet

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this in the main channel yet? If so, when did it land? Please add that info here.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the PR is still pending review, will add the info after the PR is landed

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this PR is landed in 3.37.0-0.0.pre

@sfshaza2 sfshaza2 added the review.await-update Awaiting Updates after Edits label Jun 29, 2025
chunhtai
chunhtai reviewed Jun 30, 2025
View reviewed changes
src/content/release/breaking-changes/deprecate-focusable.md
## Summary

The `SemanticsProperties.focusable` and `SemanticsConfiguration.isFocusable`
parameters were deprecated in favor of the `SemanticsProperties.focused` and
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

somwhere here should probably mention focused become nullable

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

src/content/release/breaking-changes/deprecate-focusable.md Outdated
`SemanticsConfiguration.isFocused` is a boolean to describe if the
semantics node has input focus.

The fix is the same with `SemanticsProperties.focusable` and `SemanticsProperties.focused`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This section should talk about why this we decide to deprecate isFocusable

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@sfshaza2
Copy link
Contributor

sfshaza2 commented Jul 7, 2025

@hannah-hyj, please ping me when this is ready to land

@Piinks
Copy link
Contributor

Piinks commented Sep 15, 2025

Greetings from stale PR triage! 👋
Is this change still on your radar?

@hannah-hyj
Copy link
Member Author

yes! this is still on my radar.

hannah-hyj and others added 2 commits September 17, 2025 11:46
@hannah-hyj @sfshaza2
Update src/content/release/breaking-changes/deprecate-focusable.md
988a01f 
resolve comments

Update src/content/release/breaking-changes/deprecate-focusable.md

Update src/content/release/breaking-changes/deprecate-focusable.md

Update src/content/release/breaking-changes/deprecate-focusable.md

Update src/content/release/breaking-changes/deprecate-focusable.md

Update deprecate-focusable.md

Update deprecate-focusable.md

add doc

Co-Authored-By: Shams Zakhour (ignore Sfshaza) <[email protected]>
@hannah-hyj
Update deprecate-focusable.md
a7fa637
@hannah-hyj hannah-hyj requested a review from sfshaza2 September 17, 2025 19:18
@hannah-hyj
Copy link
Member Author

@sfshaza2 this PR is ready

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chunhtai chunhtai chunhtai left review comments

@antfitch antfitch Awaiting requested review from antfitch antfitch is a code owner

@parlough parlough Awaiting requested review from parlough parlough is a code owner

@sfshaza2 sfshaza2 Awaiting requested review from sfshaza2 sfshaza2 is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
review.await-update Awaiting Updates after Edits
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@hannah-hyj @flutter-website-bot @sfshaza2 @Piinks @chunhtai