Skip to content

Conversation

xuanswe
Copy link

@xuanswe xuanswe commented Sep 5, 2025

Description of what this PR is changing or adding, and why:

In the example, when user click SelectAll icon button, the controller.selection is updated, but the focus is moved to the SelectAll icon button. Because of that, user doesn't see the selection visually. If the text field is focused again, user will see the selection.

Issues fixed by this PR (if any):

PRs or commits this PR depends on (if any):

Presubmit checklist

  • If you are unwilling, or unable, to sign the CLA, even for a tiny, one-word PR, please file an issue instead of a PR.
  • If this PR is not meant to land until a future stable release, mark it as draft with an explanation.
  • This PR follows the Google Developer Documentation Style Guidelines—for example, it doesn't use i.e. or e.g., and it avoids I and we (first-person pronouns).
  • This PR uses semantic line breaks
    of 80 characters or fewer.

In the example, when user click `SelectAll` icon button, the `controller.selection` is updated, but the focus is moved to the `SelectAll` icon button.

Visually, user doesn't see the selection. If we give the focus back to the text field, user will see the selection visually.
Copy link

google-cla bot commented Sep 5, 2025

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@xuanswe xuanswe marked this pull request as ready for review September 5, 2025 10:17
@xuanswe xuanswe requested review from sfshaza2, antfitch, parlough and a team as code owners September 5, 2025 10:17
Copy link
Contributor

@sfshaza2 sfshaza2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me, but I'm going to complete the website build before having a DRE approve. Thanks for this PR!

@sfshaza2
Copy link
Contributor

sfshaza2 commented Sep 5, 2025

/gbcrun

@sfshaza2
Copy link
Contributor

sfshaza2 commented Sep 5, 2025

@xuanswe, it looks like you didn't update the code excerpts in your PR. Can you do so?

As explained in the README file, when you update code on the site, you must run the refresh code excerpts tool:

"To resolve this error and update the Markdown snippets to match,
from the root of the website directory,
run ./dash_site refresh-excerpts."

And then update the PR.

@xuanswe
Copy link
Author

xuanswe commented Sep 5, 2025

@xuanswe, it looks like you didn't update the code excerpts in your PR. Can you do so?

As explained in the README file, when you update code on the site, you must run the refresh code excerpts tool:

"To resolve this error and update the Markdown snippets to match, from the root of the website directory, run ./dash_site refresh-excerpts."

And then update the PR.

Thanks for reviewing the PR.

Currently I don't have a linux environment to run the bash file. Instead, is it ok if I manually update the file https://github.com/flutter/website/blob/main/examples/ui/actions_and_shortcuts/lib/copyable_text.dart?

Otherwise, it would be nice if you could help me complete the missing step.

@xuanswe xuanswe requested a review from sfshaza2 September 7, 2025 07:03
@sfshaza2
Copy link
Contributor

sfshaza2 commented Sep 8, 2025

/gcbrun

@flutter-website-bot
Copy link
Collaborator

Visit the preview URL for this PR (updated for commit 2422cc7):

https://flutter-docs-prod--pr12408-patch-1-jl97rfbe.web.app

Copy link
Contributor

@sfshaza2 sfshaza2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. @khanhnwin, the code passes the build, but does this look ok to you?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants