Skip to content

Conversation

@iakdis
Copy link
Contributor

@iakdis iakdis commented Nov 7, 2025

Description of what this PR is changing or adding, and why: The problem that is described in the linked issue seems to occur due to the Templating system not working for the snippet {{site.repo.flutter}}. What differentiates the release notes pages from others is the option skipTemplateRendering in the front matter, which is set to true. While testing, removing the option from the front matter makes the link open as expected.

Issues fixed by this PR (if any): #12660

PRs or commits this PR depends on (if any):

Presubmit checklist

  • If you are unwilling, or unable, to sign the CLA, even for a tiny, one-word PR, please file an issue instead of a PR.
  • If this PR is not meant to land until a future stable release, mark it as draft with an explanation.
  • This PR follows the Google Developer Documentation Style Guidelines—for example, it doesn't use i.e. or e.g., and it avoids I and we (first-person pronouns).
  • This PR uses semantic line breaks
    of 80 characters or fewer.

@iakdis iakdis requested review from a team and sfshaza2 as code owners November 7, 2025 23:07
@google-cla
Copy link

google-cla bot commented Nov 7, 2025

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @iakdis, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a critical templating malfunction affecting numerous release notes and changelog pages. By systematically removing a specific front matter directive, skipTemplateRendering: true, the PR ensures that dynamic content, such as repository links, is correctly processed and displayed, thereby restoring the intended functionality and integrity of these documentation pages.

Highlights

  • Fixes Templating Issue: This pull request resolves an issue where the snippet {{site.repo.flutter}} was not rendering correctly on release notes pages, leading to broken links.
  • Removes skipTemplateRendering: The fix involves removing the skipTemplateRendering: true option from the front matter of various release notes and changelog Markdown files, which was identified as the cause of the templating problem.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes the skipTemplateRendering: true property from the front matter of numerous release note and changelog markdown files. This change is intended to fix an issue where a template snippet for a repository link was not being rendered correctly. The change is applied consistently across all relevant files and directly addresses the problem described. The implementation is straightforward and correct, and I have no specific comments on the changes.

Copy link
Member

@parlough parlough left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for noticing this and opening a PR to fix the issue.

Unfortunately, there's a performance issue with the Liquid templating package that we use that results in these pages taking too long to render with it. Since we haven't got around to fixing it yet, we'll need to keep skipping this for now.

Instead of doing this, could you instead replace the usage of the Liquid variables on these pages with the underlying values? I think it's fine if these usages aren't configurable.

@iakdis
Copy link
Contributor Author

iakdis commented Nov 8, 2025

I see, thank you for the information @parlough! I have reverted the changes and added a new commit which replaces the Liquid variables used on these pages according to the variable defined in site.yml.

@parlough
Copy link
Member

parlough commented Nov 8, 2025

/gcbrun

@flutter-website-bot
Copy link
Collaborator

Visit the preview URL for this PR (updated for commit b4cf0af):

https://flutter-docs-prod--pr12661-main-a1173yfo.web.app

Copy link
Member

@parlough parlough left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again for noticing this and fixing this! I really appreciate :D

@parlough parlough merged commit 82a8b02 into flutter:main Nov 8, 2025
9 checks passed
sfshaza2 pushed a commit that referenced this pull request Nov 12, 2025
The problem that is described in the linked issue seems to occur due to the
Templating system not working for the snippet `{{site.repo.flutter}}`.
What differentiates the release notes pages from others is the option
`skipTemplateRendering` in the front matter, which is set to `true`.
Fix this by replacing the usage of template variables with the underlying values.

Fixes #12660
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants