-
Notifications
You must be signed in to change notification settings - Fork 3.4k
Fix a few unmigrated Liquid usages #12708
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @parlough, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request completes the migration from Liquid templating to Jaspr components for specific UI elements, addressing previously unmigrated instances of tabs and YouTube embeds. The changes ensure that the content rendering aligns fully with the Jaspr framework. Additionally, a minor CSS adjustment was made to improve the spacing within tab panes, and the associated style hash was updated. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request effectively continues the migration from Liquid tags to Jaspr components by updating several markdown files. The changes correctly replace {% tabs %} and {% ytEmbed %} with their <Tabs> and <YouTubeEmbed> counterparts. Additionally, a related SCSS improvement for the tabs component enhances spacing, and the corresponding style hash is updated. My review includes a couple of minor suggestions to improve content consistency in one of the updated markdown files.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
|
Visit the preview URL for this PR (updated for commit 937dbba): https://flutter-docs-prod--pr12708-fix-unmigrated-liquid-usage-68fnf0c5.web.app |
sfshaza2
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
These must have accidentally got missed around when we were merging the Jaspr migration in.
Staged: https://flutter-docs-prod--pr12708-fix-unmigrated-liquid-usage-68fnf0c5.web.app/ui/accessibility/assistive-technologies#screen-readers