Skip to content

Conversation

@parlough
Copy link
Member

@parlough parlough commented Nov 18, 2025

These must have accidentally got missed around when we were merging the Jaspr migration in.

Staged: https://flutter-docs-prod--pr12708-fix-unmigrated-liquid-usage-68fnf0c5.web.app/ui/accessibility/assistive-technologies#screen-readers

@parlough parlough requested review from a team and sfshaza2 as code owners November 18, 2025 02:14
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @parlough, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request completes the migration from Liquid templating to Jaspr components for specific UI elements, addressing previously unmigrated instances of tabs and YouTube embeds. The changes ensure that the content rendering aligns fully with the Jaspr framework. Additionally, a minor CSS adjustment was made to improve the spacing within tab panes, and the associated style hash was updated.

Highlights

  • Liquid to Jaspr Migration: Migrated all remaining Liquid {% tabs %}, {% tab %}, and {% ytEmbed %} syntax to their corresponding Jaspr <Tabs>, <Tab>, and <YouTubeEmbed /> components in markdown content files.
  • CSS Styling Adjustment: Added a margin-block-end of 1rem to the last child element within tab panes to ensure consistent spacing and visual presentation.
  • Style Hash Update: Updated the generatedStylesHash constant in style_hash.dart to reflect the latest changes in the main.css file, likely due to the CSS styling adjustment.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request effectively continues the migration from Liquid tags to Jaspr components by updating several markdown files. The changes correctly replace {% tabs %} and {% ytEmbed %} with their <Tabs> and <YouTubeEmbed> counterparts. Additionally, a related SCSS improvement for the tabs component enhances spacing, and the corresponding style hash is updated. My review includes a couple of minor suggestions to improve content consistency in one of the updated markdown files.

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
@flutter-website-bot
Copy link
Collaborator

flutter-website-bot commented Nov 18, 2025

Visit the preview URL for this PR (updated for commit 937dbba):

https://flutter-docs-prod--pr12708-fix-unmigrated-liquid-usage-68fnf0c5.web.app

Copy link
Contributor

@sfshaza2 sfshaza2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@sfshaza2 sfshaza2 merged commit 09f69f7 into main Nov 20, 2025
9 checks passed
@sfshaza2 sfshaza2 deleted the fix/unmigrated-liquid-usages branch November 20, 2025 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants