Skip to content

Conversation

@diegotori
Copy link
Collaborator

@diegotori diegotori commented Apr 17, 2025

Looks like the header files weren't referenced properly in the iOS platform channel. Also upgraded Pigeon to the latest version.

Addresses issue #94.

@diegotori
Copy link
Collaborator Author

LGTM. Skipping dart format failures, since this is not critical for fixing this issue.

@diegotori diegotori merged commit e64c358 into fluttercommunity:main Apr 17, 2025
12 of 14 checks passed
@diegotori diegotori deleted the fix_spm_integration branch April 17, 2025 19:51
@Gustl22
Copy link
Contributor

Gustl22 commented May 21, 2025

I kind of wonder, why this problem happened: I added the source files via podspec:

s.public_header_files = 'wakelock_plus/Sources/wakelock_plus/include/**/*.h'

We should not need relative imports.

The same way it's done in flutter (e.g.:):
https://github.com/flutter/packages/blob/main/packages/video_player/video_player_avfoundation/darwin/video_player_avfoundation.podspec

@Gustl22
Copy link
Contributor

Gustl22 commented May 21, 2025

This might be the same problem as:
https://github.com/firebase/flutterfire/pull/11472/files, but I also wonder, why the official packages don't have this problem, probably because they use the same messages.g.m class for ios and macos (just a guess)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants