Skip to content

Conversation

@JaeseungYeom
Copy link
Contributor

This PR depends on PR #91

This PR implements set-associative cache with LRU replacement scheme as well as basic priority-based replacement scheme.
This includes a test.

@JaeseungYeom JaeseungYeom self-assigned this Feb 7, 2024
@JaeseungYeom JaeseungYeom added enhancement New feature or request good first issue Good for newcomers labels Feb 7, 2024
@JaeseungYeom JaeseungYeom force-pushed the residency branch 4 times, most recently from b33d9b7 to ac72151 Compare February 8, 2024 05:22
@JaeseungYeom JaeseungYeom marked this pull request as draft February 11, 2024 23:22
@ilumsden
Copy link
Collaborator

Note: this PR adds a dependency on Boost

@ilumsden
Copy link
Collaborator

Another option that we could use to support both std::filesystem and std::experimental::filesystem: https://github.com/vector-of-bool/CMakeCM/blob/master/modules/FindFilesystem.cmake

@JaeseungYeom
Copy link
Contributor Author

Another option that we could use to support both std::filesystem and std::experimental::filesystem: https://github.com/vector-of-bool/CMakeCM/blob/master/modules/FindFilesystem.cmake
This PR does not use boost filesystem if that is what you are referring. The dependency is for boost::multi_index.
BTW, I think we had some cmake test for detecting which is available and then setting a macro. Based on that, you can choose which to use in your source code. In any case, std::filesystem is fully incorporated after c++17. std::experimental did not work that well for me. Either something is not working or something is missing.

@JaeseungYeom JaeseungYeom marked this pull request as ready for review July 10, 2025 01:07
@wangvsa
Copy link
Collaborator

wangvsa commented Jul 10, 2025

Just a note here. This PR implements a caching algorithm, but currently is unconnected with the rest of DYAD. We will use this algorithm to implement consumer-side file-based caching (in a separate PR).

Copy link
Collaborator

@wangvsa wangvsa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I will merge this PR first then integrate it with my side of code to implement the consumer-side caching. The integration may take some time and testing will be time-consuming as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request good first issue Good for newcomers

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants