-
Notifications
You must be signed in to change notification settings - Fork 22
improve FAQ entry about filling up /tmp
#306
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Problem: The FAQ entry about filling up `/tmp` uses a different path for `statedir` when creating the directory vs using it in a job. This is confusing for users. Fix the typo.
faqs.rst
Outdated
| some situations such as long running, high throughput workflows, Flux may | ||
| use a lot of it. | ||
| When the FLux database fills up the disk, errors like the following may |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| When the FLux database fills up the disk, errors like the following may | |
| When the Flux database fills up the disk, errors like the following may |
faqs.rst
Outdated
| .. code-block:: console | ||
| content-sqlite.err[0]: store: executing stmt: database or disk is full(13) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: can we be consistent with spacing for code blocks? This one has indentation that is much smaller than the others.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry I copied the example right before this code block which has an indent of 1. There are also code blocks in this file with indent of 2, 3, and 4. I'll tack on an extra commit to standardize on 4.
Edit: actually I used 2. 4 seems excessive and most code-blocks were using 2 space indent.
Problem: There are no example errors in the FAQ entry about full `/tmp`, but this may be useful for users searching for errors via a search engine. Add some example errors to the FAQ entry.
Problem: An example in the FAQ uses `flux start -o,-S...`, an outdated usage. Update the example to `flux start -S...`.
Problem: Some code-blocks in faqs.rst use different number of spaces for the indent. Change all the indents to 2 spaces.
|
Thanks @vsoch! I addressed your comments. I also noticed an outdated usage of |
Problem: Linkcheck fails in ci for https://mcs.anl.gov/papers, but this link works fine outside of github. Add the paper URL to the list of linkcheck errors to ignore.
Problem: The Spack project install link is broken. Drop the `#install` from the URL.
@ryanday36 noticed a typo in the FAQ entry on using
statedir. Additionally, it was suggested that adding some example errors would be helpful here.