-
Notifications
You must be signed in to change notification settings - Fork 47
cmake: Bump required flux-core version #1391
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
problem: recent PRs have added things that require more recent flux versions and not added any check for the version being found solution: add the required version into the pkg_check_modules call in cmake/FindFluxCore.cmake
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1391 +/- ##
========================================
Coverage ? 77.2%
========================================
Files ? 114
Lines ? 16320
Branches ? 0
========================================
Hits ? 12609
Misses ? 3711
Partials ? 0 🚀 New features to boost your workflow:
|
Hm, I didn't think the intent of any recent PR was to bump the required version of flux-core (yet). Do we know what exactly caused the incompatibility? It might be nice to fix that and allow flux-sched to still be built alongside the deployed version of core. |
It may actually pass, I misread how the flags were being added in 1390, if so this version should change, but we should be tracking a working target version this way so that users get an appropriate message when trying to use one that's too old. |
#1390 just sets a broker attribute in some tests. That broker attribute doesn't exist in previous releases but setting an unknown attribute isn't treated as an error, for better or worse. |
I am getting errors running |
I saw some issues in another PR that look related to the recently merged feasibility module seemingly interacting with the post-load error behavior. Not sure why it didn’t show up in the other PR though, maybe only shows up after the Core Image update?
Get Outlook for iOS<https://aka.ms/o0ukef>
…________________________________
From: Mark Grondona ***@***.***>
Sent: Tuesday, August 19, 2025 1:33:45 PM
To: flux-framework/flux-sched ***@***.***>
Cc: Scogland, Tom ***@***.***>; Author ***@***.***>
Subject: Re: [flux-framework/flux-sched] cmake: Bump required flux-core version (PR #1391)
[https://avatars.githubusercontent.com/u/741970?s=20&v=4]grondo left a comment (flux-framework/flux-sched#1391)<https://urldefense.us/v3/__https://github.com/flux-framework/flux-sched/pull/1391*issuecomment-3202138770__;Iw!!G2kpM7uM-TzIFchu!xvOJw7YJmPjDywz7B3WClmLiovoXyzSDNMXrS1gQPF26wabELTxtrOw7Nb3WJ07Z4biNX_D3Kszbd-QFPlGZoATr6ZA$>
I am getting errors running make check on a TOSS 4 system with flux-core v0.76.0. However, I went back to the latest flux-sched tag and still seem to get the same errors, so my feeling is that this is a Fluxion testsuite error and not any dependence on a given version of flux-core. I haven't run down the source of the errors yet though (actually I wonder if anyone else has issues, or perhaps it is user error on my part)
—
Reply to this email directly, view it on GitHub<https://urldefense.us/v3/__https://github.com/flux-framework/flux-sched/pull/1391*issuecomment-3202138770__;Iw!!G2kpM7uM-TzIFchu!xvOJw7YJmPjDywz7B3WClmLiovoXyzSDNMXrS1gQPF26wabELTxtrOw7Nb3WJ07Z4biNX_D3Kszbd-QFPlGZoATr6ZA$>, or unsubscribe<https://urldefense.us/v3/__https://github.com/notifications/unsubscribe-auth/AAFBFNJ4AW77EQL7NX4CZIT3OOC2TAVCNFSM6AAAAACEI7ZFXWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTEMBSGEZTQNZXGA__;!!G2kpM7uM-TzIFchu!xvOJw7YJmPjDywz7B3WClmLiovoXyzSDNMXrS1gQPF26wabELTxtrOw7Nb3WJ07Z4biNX_D3Kszbd-QFPlGZ4hGSlZo$>.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
Were the errors like these? https://github.com/flux-framework/flux-sched/actions/runs/17078065102/job/48424613295#step:6:2084 I’m not 100% sure why, but a couple of different PRs got those errors for a while earlier today, then they seemed to be resolved. Not sure why… |
It doesn't appear to be similar, though I may need to do more testing. Here's an example failure from
(with more cascading failures as the test progresses) |
Huh... where were you testing? I just built and ran |
Hm, this was tuolumne. I was also wondering if it is something in my environment. Sorry I haven't had a chance to run this down yet. |
problem: recent PRs have added things that require more recent flux versions and not added any check for the version being found
solution: add the required version into the pkg_check_modules call in cmake/FindFluxCore.cmake
Related to #1390