Use simpler constructor to cast from chrono_tz::Tz#141
Open
WhyNotHugo wants to merge 6 commits intofmeringdal:mainfrom
Open
Use simpler constructor to cast from chrono_tz::Tz#141WhyNotHugo wants to merge 6 commits intofmeringdal:mainfrom
WhyNotHugo wants to merge 6 commits intofmeringdal:mainfrom
Conversation
Fixes CI failure.
Fixes CI failure.
Using the nightly compiler is a burden for contributors — a lot of platforms don't ship builds of the nightly compiler. In order to use nightly, we'd need to compile it from source.
macOS CI builders run on aarch64, but CI attempts to fetch the toolchain for x86_64.
WhyNotHugo
force-pushed
the
tz-constructor
branch
from
914dd8c to
28d30c0
Compare
Contributor
Author
|
Currently includes commits from https://github.com//rust-rrule/pull/140, should be rebased once that is merged. |
Instead of generating one const variant of Tz for each chrono_tz::tz
variant, provide a const function to convert chrono_tz::Tz into Tz in a
static context.
The main change here is the introduction of Tz::from_static(). Other
changes merely adapt existing code to use this instead of chrono_tz
directly.
Usages such as:
Tz::America__Los_Angeles;
Become:
Tz::from_static(chrono_tz::America::Los_Angeles)
WhyNotHugo
force-pushed
the
tz-constructor
branch
from
28d30c0 to
1b1c473
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of generating one const variant of Tz for each chrono_tz::tz variant, provide a const function to convert chrono_tz::Tz into Tz in a static context.
The main change here is the introduction of Tz::from_static(). Other changes merely adapt existing code to use this instead of chrono_tz directly.
Usages such as:
Become: