feat: add dst-fold-first feature for handling ambiguous DST times#145
Open
zhwei wants to merge 1 commit intofmeringdal:mainfrom
Open
feat: add dst-fold-first feature for handling ambiguous DST times#145zhwei wants to merge 1 commit intofmeringdal:mainfrom
zhwei wants to merge 1 commit intofmeringdal:mainfrom
Conversation
Add a new feature flag 'dst-fold-first' that changes the behavior when encountering ambiguous local times during DST transitions. Behavior: - Without feature: Returns error for ambiguous DST times - With feature enabled: Picks the first (earlier) occurrence Implementation: - parser/datetime.rs: Handle Ambiguous LocalResult by selecting first datetime - iter/utils.rs: Handle Ambiguous LocalResult in add_time_to_date function Tests (America/Mexico_City 2021-2022 DST transitions): - dst_ambiguous_time_returns_error: Verifies error without feature - dst_fold_first_picks_earlier_time: Verifies first (-05:00) is selected - dst_fold_first_mexico_city_yearly: Tests yearly recurrence across DST Note: Only affects 'Ambiguous' LocalResult (fall back overlap), not 'None' (spring forward gap). Mexico eliminated DST after 2022. Usage: cargo build --features dst-fold-first
Author
|
It looks like the lints test was already broken before this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a new feature flag 'dst-fold-first' that changes the behavior when encountering ambiguous local times during DST transitions.
Behavior:
Implementation:
Tests (America/Mexico_City 2021-2022 DST transitions):
Note: Only affects 'Ambiguous' LocalResult (fall back overlap), not 'None' (spring forward gap). Mexico eliminated DST after 2022.
Usage:
cargo build --features dst-fold-first