fix: add missing FORMATS and LIBNAMES entries for musl platforms#33
Merged
fix: add missing FORMATS and LIBNAMES entries for musl platforms#33
Conversation
- Add aarch64-linux-musl to FORMATS for binary verification - Add x86_64-linux-musl and aarch64-linux-musl to LIBNAMES Without these entries, verify_lib would skip format verification and lib_fullpath would return nil for musl targets. Tested on Alpine Linux ARM64 - the existing aarch64-linux-musl gem already works correctly due to RubyGems platform normalization. Closes #11
ronaldtse
force-pushed
the
fix/add-musl-platform-entries
branch
from
3a63430 to
a84c3da
Compare
Cache ports/ and tmp/ directories to speed up builds. The cache key is based on platform and recipe file hashes, so changes to configuration or build recipes will invalidate the cache.
ronaldtse
force-pushed
the
fix/add-musl-platform-entries
branch
from
0de90b5 to
b1bc29d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
aarch64-linux-musltoFORMATSfor binary verificationx86_64-linux-muslandaarch64-linux-musltoLIBNAMEScross_compiler_envto usecase/when(RuboCop)Background
Issue #11 requested support for Alpine Linux on ARM64. Testing revealed that the existing
aarch64-linux-muslgem already works on Alpine Linux because:aarch64-linux-musl(notaarch64-alpine-linux-musl)However, during investigation, I found that
FORMATSandLIBNAMESwere missing entries for musl platforms. Without these:verify_libwould skip format verification for musl targetslib_fullpathwould returnnilfor musl targetsTesting
Verified on Alpine Linux ARM64 via Docker:
Closes #11