Skip to content

Conversation

AlemTuzlak
Copy link
Contributor

Fixes #

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context.
List any dependencies that are required for this change.

Type of change

Please mark relevant options with an x in the brackets.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Algorithm update - updates algorithm documentation/questions/answers etc.
  • Other (please describe):

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also
list any relevant details for your test configuration

  • Integration tests
  • Unit tests
  • Manual tests
  • No tests required

Reviewer checklist

Mark everything that needs to be checked before merging the PR.

  • Check if the UI is working as expected and is satisfactory
  • Check if the code is well documented
  • Check if the behavior is what is expected
  • Check if the code is well tested
  • Check if the code is readable and well formatted
  • Additional checks (document below if any)

Screenshots (if appropriate):

Questions (if appropriate):

Copy link
Contributor

@thomasfr thomasfr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While this definitely makes handling the language parameter in the code much easier, it also completely prevents the easy and cheap use of edge caching for HTML pages, with Cloudflare. Currently, you can safely cache everything on CF with a "Cache Rule" because a given URL always returns the same response for all website visitors. However, mixing query parameters and cookie values for the language parameter prevents automatic HTML edge caching through a "Cache Rule." Only with the Cloudflare Business Plan ($200/month/domain) can you use cookie values as part of the cache key.

I suggest not changing this for now, perhaps we can find a better solution that addresses both scenarios or document alternative approaches and their implications.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants