fix(insert): allow insertion only if same group parents or accepts is true
#152
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…` is true if none is provided, it'll allow the insertion by default (just like today, so no real breaking change)
|
@Vexcited is attempting to deploy a commit to the Formkit Team on Vercel. A member of the Team first needs to authorize it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as of right now, using insert() plugin will allow insertion to every group without checking them.
this PR regulates how it works and will check if we're in the same "group" (from parent config) or if the parent "accepts()" the insertion.
if none is provided of them, it'll allow the insertion by default (just like today)
resolves
insertplugin breaks grouping rules #151