Skip to content

Fixed #625: README states error generating command for npm #626

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: development
Choose a base branch
from
Open

Fixed #625: README states error generating command for npm #626

wants to merge 1 commit into from

Conversation

@simsausaurabh
Copy link
Member

@simsausaurabh simsausaurabh commented Feb 16, 2018

Fixes #625

screenshot from 2018-02-16 16-11-17

@mariobehling please review

@simsausaurabh
Copy link
Member Author

simsausaurabh commented Feb 16, 2018 •
edited
Loading

CI is failing because package.json is set to use "node": ">=0.12.x" and travis-ci is testing on node v0.10.26
which fails to install few npm module leading to travis failure. travis.yml needs to be updated.

npm ERR! at /home/travis/.nvm/v0.10.26/lib/node_modules/npm/node_modules/graceful-fs/polyfills.js:133:7

@singhpratyush
Copy link
Member

singhpratyush commented Feb 16, 2018

@simsausaurabh: Please open an issue for the Travis build.

@simsausaurabh
Copy link
Member Author

simsausaurabh commented Feb 16, 2018

@singhpratyush 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@abishekvashok abishekvashok abishekvashok approved these changes

@bhaveshAn bhaveshAn bhaveshAn approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@simsausaurabh @singhpratyush @abishekvashok @bhaveshAn