Fix 496 #497
Open
Fix 496 #497
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ms10398
reviewed
Dec 6, 2018
src/js/options.js
Outdated
| }, (stream) => { | ||
| stream.getTracks().forEach(track => track.stop()); | ||
| displayNotification('success', ' Mic Access Granted', 1000); | ||
|
|
Member
There was a problem hiding this comment.
Can you remove the extra blank line
ms10398
reviewed
Dec 6, 2018
src/js/options.js
Outdated
| localStorage.setItem("theme",theme); | ||
| alert("Success"); | ||
| }); | ||
| displayNotification('info', 'Theme successfully changed', 1000); |
Member
There was a problem hiding this comment.
Can you please make the indentation consistent?
ms10398
requested changes
Dec 6, 2018
Member
ms10398
left a comment
ms10398
left a comment
There was a problem hiding this comment.
Please do the requested changes
rajvaibhavdubey
suggested changes
Dec 6, 2018
Member
rajvaibhavdubey
left a comment
rajvaibhavdubey
left a comment
There was a problem hiding this comment.
Fix the conflicts, else LGTM 👍
championpaddler
force-pushed
the
Fix-496
branch
from
c72c74e to
6766b29
Compare
Member
Author
|
@ms10398 Done Now. |
Member
Author
|
@ms10398 @stealthanthrax Please review. |
Member
Author
|
@ms10398 @mariobehling Please review. |
Member
Author
|
@hkedia321 Please approve this also. |
Member
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #496
Checklist
masterbranch.Changes proposed in this pull request: