Skip to content

Conversation

@hardikhere
Copy link

overlapping of scrollIconUp/Bottom with scollbar is fixed and login page's top margin fixed.

Issue #550 and #549 is resolved kindly check it out.

Fixes #

Checklist

  • I have read the Contribution & Best practices Guide and my PR follows them.
  • My branch is up-to-date with the Upstream master branch.
  • The unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation

Issues

currently, the scroll icon is overlapping with the scroll bar.
also some text may hide behind the scroll icon.

overlapping

Also, there is unnecessary top margin on
the login page, which hides other options.

Changes proposed in this pull request:

2

22

overlapping of scrollIconUp/Bottom with scollbar is fixed and login page's top margin fixed.
@hardikhere hardikhere changed the title update style.css & login.css Solved: overlapping Issue of ScrollIcon and top margin Issue of login page Oct 26, 2019
Copy link
Member

@Dishebh Dishebh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kindly open separate PRs for different issues.

@harshit-soora
Copy link

Hey @hardikhere
I'm new to this open source environment, I just had one concern.
After you edit your changes, do we have to build the code or something
In my case, Travis CI build fails

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants