Skip to content

fix(easy-install): pull tagged frappe_docker instead of main#1697

Open
DanielRadlAMR wants to merge 1 commit intofrappe:developfrom
AMR-Mannesmann:hotfix-for-frappe_docker-breaking-changes
Open

fix(easy-install): pull tagged frappe_docker instead of main#1697
DanielRadlAMR wants to merge 1 commit intofrappe:developfrom
AMR-Mannesmann:hotfix-for-frappe_docker-breaking-changes

Conversation

@DanielRadlAMR
Copy link

What type of a PR is this?

  • Changes to Existing Features
  • New Feature Submissions
  • Bug Fix
  • Breaking Change (include change in API behaviours, etc.)

Please provide enough information so that others can review your pull request:

frappe_docker recently introduced breaking changes. This PR is a hotifx, it pulls the latest tag before the breaking change, instead of the main branch. This is not a final solution, as the easy-install script should be migrated correctly.

#1696

@akhilnarang akhilnarang changed the title !fix(easy-install): pull tagged frappe_docker instead of main fix(easy-install): pull tagged frappe_docker instead of main Feb 10, 2026
@DanielRadlAMR DanielRadlAMR force-pushed the hotfix-for-frappe_docker-breaking-changes branch from 2aa8ae3 to aa5f941 Compare February 10, 2026 11:08
@sonarqubecloud
Copy link

@asieftejani
Copy link

Hi @DanielRadlAMR
I am checking the changes - I think there is a mistake - it should be v1.0.0 (which has image: traefik:v2.11 in https://github.com/frappe/frappe_docker/blob/v1.0.0/overrides/compose.proxy.yaml) and not v1.0.1(which has image: traefik:v3.6 in https://github.com/frappe/frappe_docker/blob/v1.0.1/overrides/compose.proxy.yaml)
Please can you double chek and confim

@DanielRadlAMR
Copy link
Author

v1.0.1 was the lates version before the breaking change.

Although it runs on Traefik v3, the appropriate compatibility flags are enabled to preserve v2 syntax behavior.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants