Skip to content

feat(billing): Create mandates for UPI to autopay#5163

Merged
Bowrna merged 5 commits intofrappe:developfrom
Bowrna:razorpay_upi_emandate
Mar 23, 2026
Merged

feat(billing): Create mandates for UPI to autopay#5163
Bowrna merged 5 commits intofrappe:developfrom
Bowrna:razorpay_upi_emandate

Conversation

@Bowrna
Copy link
Copy Markdown
Contributor

@Bowrna Bowrna commented Feb 18, 2026

No description provided.

@Bowrna Bowrna force-pushed the razorpay_upi_emandate branch 2 times, most recently from 79f512d to 9b0c5ca Compare March 16, 2026 04:45
@Bowrna Bowrna force-pushed the razorpay_upi_emandate branch from 9b5eb59 to 60998b0 Compare March 18, 2026 07:10
Comment thread dashboard/src/components/billing/UPIAutopayForm.vue
fieldname: 'status',
type: 'Component',
component({ row }) {
const statusColors = {
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

badge colours are fetched from badge.vue file. Can we add these there?

{
label: 'Expires On',
fieldname: 'expires_on',
type: 'Date',
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lets also format date values, like we have in invoice and balance list views
Those are more human readable

Comment thread dashboard/src/pages/BillingUPIAutopay.vue Outdated
Comment thread press/api/billing.py Outdated
Comment thread press/api/billing.py
Comment thread press/press/doctype/invoice/invoice.py Outdated
Comment thread press/press/doctype/invoice/invoice.py Outdated
@Bowrna Bowrna force-pushed the razorpay_upi_emandate branch from d65259d to 3176973 Compare March 19, 2026 10:02
Completed: 'green',
Deployed: 'green',
Expired: 'red',
Expired: 'gray',
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's keep expired as red only. This is used at other places as well.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I verified and it was not used in other places @shadrak98 . Thats why i changed it here to gray as it makes more sense. But if you think it was for common use case, i will extend this part and use gray in place for upi autopay part. Let me know what do you think.

@Bowrna Bowrna force-pushed the razorpay_upi_emandate branch from 3492f18 to b8e9ae8 Compare March 23, 2026 07:03
@Bowrna Bowrna marked this pull request as ready for review March 23, 2026 07:03
@Bowrna Bowrna requested a review from regdocs as a code owner March 23, 2026 07:03
@Bowrna Bowrna enabled auto-merge March 23, 2026 07:04
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 23, 2026

Codecov Report

❌ Patch coverage is 9.48276% with 420 lines in your changes missing coverage. Please review.
✅ Project coverage is 50.74%. Comparing base (b784cf9) to head (9cd208b).
⚠️ Report is 7 commits behind head on develop.

Files with missing lines Patch % Lines
...press/doctype/razorpay_mandate/razorpay_mandate.py 0.00% 122 Missing ⚠️
...ctype/razorpay_webhook_log/razorpay_webhook_log.py 0.00% 110 Missing ⚠️
press/press/doctype/invoice/invoice.py 8.10% 102 Missing ⚠️
press/api/billing.py 22.22% 63 Missing ⚠️
press/press/doctype/team/team.py 14.81% 23 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##           develop    #5163       +/-   ##
============================================
- Coverage    73.05%   50.74%   -22.32%     
============================================
  Files          106      875      +769     
  Lines        17046    72489    +55443     
  Branches       272      273        +1     
============================================
+ Hits         12453    36784    +24331     
- Misses        4571    35682    +31111     
- Partials        22       23        +1     
Flag Coverage Δ
dashboard 73.05% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Bowrna Bowrna merged commit ac82a44 into frappe:develop Mar 23, 2026
4 of 6 checks passed
Bowrna added a commit that referenced this pull request Mar 26, 2026
feat(billing): Create mandates for UPI to autopay (backport #5163)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants