GEOM: add a new function g_new_geom #1786
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for taking the time to contribute to FreeBSD!
Please review CONTRIBUTING.md, then update and push your branch again. |
|
We should avoid modifying openzfs code, since that comes from its own upstream. There is a style bug in g_new_geom()--could you please fix it? With that, this commit is fine to merge. |
bsdjhb
reviewed
Jul 25, 2025
bsdjhb
reviewed
Jul 25, 2025
This function is a variant of g_new_geomf. It accepts a regular string instead of a format string as its input parameter. It can save the time wasted on unnecessary format string processing.
|
The first commit here looks good to me. Adding a second commit to convert existing callers that didn't need formatting as was done in the original PR would be nice to have as well. |
freebsd-git
pushed a commit
that referenced
this pull request
Sep 5, 2025
This function is a variant of g_new_geomf. It accepts a regular string instead of a format string as its input parameter. It can save the time wasted on unnecessary format string processing. Reviewed by: imp Pull Request: #1786
freebsd-git
pushed a commit
that referenced
this pull request
Sep 5, 2025
…_geomf Reviewed by: imp Pull Request: #1786
…_geomf Signed-off-by: Wuyang Chung <[email protected]>
wy-chung
force-pushed
the
wyc/g_new_geom
branch
from
e4b9771 to
f6322ee
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This function accepts a regular string as its input string so the callers calling this function can save the time wasted on format string processing.