NEWS: minor corrections #2395
Open
NEWS: minor corrections #2395
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Spelling and other suggestions.
|
Draft (first and second passes, reading quickly). I can make a more thorough pass, later. Change osx and MacOS to macOS? |
A quick second pass. Not comprehensive. (I noticed a few minor issues immediately after the first pass.)
grahamperrin
commented
Jan 1, 2025
| * actions_script: script version of 'actions' in lua | ||
| * lua scripts: now can have real arguments instead of | ||
| pre-expended ones | ||
| pre-expended ones |
There was a problem hiding this comment.
Suggested change
| pre-expended ones | |
| pre-expanded ones |
(I'm not sure about this change.)
| - Fix build on osx | ||
| - Fix libelf detection on debian | ||
| - Fix libelf detection on Debian | ||
| - Fix pkg_shutdown unproperly reinitializing closed fds |
There was a problem hiding this comment.
Suggested change
| - Fix pkg_shutdown unproperly reinitializing closed fds | |
| - Fix pkg_shutdown unproperly reinitializing closed file descriptors |
| - fix duplicate pkg registration overwriting the existing pkg | ||
| - better ABI name on linux | ||
| - better ABI name on Linux | ||
| - lots of changes in internal API to use fd when possible |
There was a problem hiding this comment.
Suggested change
| - lots of changes in internal API to use fd when possible | |
| - lots of changes in internal API to use file descriptor when possible |
There was a problem hiding this comment.
(I'm not sure about this.)
| - move more pkg audit details into the library | ||
| - allow to run pkg query without any privileges | ||
| - extend the audit periodic script to report deprecated packages | ||
| - Fix fd leak to rcscripts |
There was a problem hiding this comment.
fd leak or file descriptor leak?
I guess, this was meant to be: 1.21.99.5 to 1.21.99.6
1.21.99.6 to 1.21.99.6 seems incorrect (the two are equal to each other). So, my attempt to correct two sets of changes: 1.21.99.5 to 1.21.99.6, then 1.21.99.6 to 2.0.99.
|
can you rebase? |
|
I probably can rebase, although my (little) Git knowledge has largely evaporated over the past year or so. I'll need a very clear head, so, maybe mid-September. Thanks for your patience. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Spelling and other suggestions.