-
Notifications
You must be signed in to change notification settings - Fork 161
Remove root parameter override in watch mode #925
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from 5 commits
112b921
dfa48cc
6cd58b9
22f4feb
6e67326
f9ac119
aa0ea07
0dcda55
61ed808
2df3a2c
f1fd7b3
6a313ab
d2e196c
4700b62
86296aa
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||||||
|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -1403,26 +1403,10 @@ type CoreBuildOptions(watch) = | |||||||||
|
|
||||||||||
| let userParametersDict = readOnlyDict userParameters | ||||||||||
|
|
||||||||||
| // Adjust the user substitutions for 'watch' mode root | ||||||||||
| let userRoot, userParameters = | ||||||||||
| if watch then | ||||||||||
| let userRoot = sprintf "http://localhost:%d/" this.port_option | ||||||||||
|
|
||||||||||
| if userParametersDict.ContainsKey(ParamKeys.root) then | ||||||||||
| printfn "ignoring user-specified root since in watch mode, root = %s" userRoot | ||||||||||
|
|
||||||||||
| let userParameters = | ||||||||||
| [ ParamKeys.root, userRoot ] | ||||||||||
| @ (userParameters |> List.filter (fun (a, _) -> a <> ParamKeys.root)) | ||||||||||
|
|
||||||||||
| Some userRoot, userParameters | ||||||||||
| else | ||||||||||
| let r = | ||||||||||
| match userParametersDict.TryGetValue(ParamKeys.root) with | ||||||||||
| | true, v -> Some v | ||||||||||
| | _ -> None | ||||||||||
|
|
||||||||||
| r, userParameters | ||||||||||
| let userRoot = | ||||||||||
|
||||||||||
| let root = | |
| let projectUrl = projectInfoForDocs.PackageProjectUrl |> Option.map ensureTrailingSlash | |
| defaultArg userRoot (defaultArg projectUrl ("/" + collectionName) |> ensureTrailingSlash) |
Just following the instructions in the readme (dotnet build and src\fsdocs-tool\bin\Debug\net6.0\fsdocs.exe watch) will launch everything pointing to https://fsprojects.github.io/FSharp.Formatting and not localhost.
Uh oh!
There was an error while loading. Please reload this page.