Skip to content

Conversation

@nojaf
Copy link
Contributor

@nojaf nojaf commented Aug 4, 2025

Fixes #3175

@nojaf nojaf marked this pull request as ready for review August 5, 2025 08:26
@nojaf nojaf requested a review from dawedawe August 5, 2025 08:27
@nojaf
Copy link
Contributor Author

nojaf commented Aug 5, 2025

@TheAngryByrd maybe "a version" of this merging process should be available somewhere in the analyzer SDK? Perhaps a sub command in the cli tool, I don't quite know where but this would be useful.

Alternatively, if the cli tool accepts multiple fsprojs and only creates a single output file the problem is solved as well.

@TheAngryByrd
Copy link
Contributor

Yeah I was going to suggest adding this to analyzers cli. —merge-sarif with a list/glob would be fine enough.

@Numpsy
Copy link
Contributor

Numpsy commented Aug 6, 2025

As an aside, how close is all that Sarif merger code to being able to write the sarif files to begin with, so it's all self contained rather than using Sarif.Sdk?
Asking because I once borrowed a bunch of the Sarif code from the Analyzers SDK to do fsprojects/FSharpLint#702 and I wonder if a completed version of that might find the merge code useful as well.

@nojaf
Copy link
Contributor Author

nojaf commented Aug 6, 2025

@Numpsy yes, there probably is some sarif synergy possible.
Though, I'm leaning a bit more towards the analyzers cli being able to accept multiple projects. That might be the more interesting fix for this problem.

@nojaf nojaf merged commit cbee488 into fsprojects:main Aug 6, 2025
8 of 9 checks passed
@Numpsy
Copy link
Contributor

Numpsy commented Aug 23, 2025

Though, I'm leaning a bit more towards the analyzers cli being able to accept multiple projects. That might be the more interesting fix for this problem.

Actually I think the current versions of FSharpLint can be pointed at a single solution or solution filter and will then just generate a single report containing all the projects in the solution (though that will always do everything, you can't do a whole solution and exclude one project)

@nojaf nojaf mentioned this pull request Sep 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Sarif file update

4 participants