Handle no wkt but supplied units #52
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MeganDawson42
requested review from
BenCurran98,
i-kieu,
mazadbakht,
n6171028 and
zqiaofugro
i-kieu
previously approved these changes
Apr 17, 2025
BenCurran98
reviewed
Apr 17, 2025
src/read.jl
Outdated
| else | ||
| @assert count(these_are_wkts) == 1 "Expected to find 1 OGC WKT VLR, instead found $(count(these_are_wkts))" | ||
| ogc_wkt = get_data(vlrs[findfirst(these_are_wkts)]) | ||
| ogc_wkt = if count(these_are_wkts) != 1 |
There was a problem hiding this comment.
Probably should make this count(these_are_wkts) == 0 and cover the case where we have 2 or more specifications (since that's a valid error I think?)
BenCurran98
previously approved these changes
Apr 17, 2025
Signed-off-by: Megan Dawson <[email protected]>
Signed-off-by: Megan Dawson <[email protected]>
Signed-off-by: Megan Dawson <[email protected]>
MeganDawson42
force-pushed
the
handle_no_wkt_but_supplied_units
branch
from
c2a9be1 to
493bd52
Compare
BenCurran98
approved these changes
Apr 17, 2025
zqiaofugro
approved these changes
Apr 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handle no wkt but supplied units
Description
allow units to be supplied and used even if there is no ogc_wkt and fixed the plumbing through of the verbose kwarg
Types of Changes
Review
List of tasks the reviewer must do to review the PR