Skip to content

Provide defaults if Fullstory module doesn't exist #143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
RyanCommits merged 3 commits into from
Feb 5, 2026
Merged

Provide defaults if Fullstory module doesn't exist #143

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d2c0525
provide defaults for TV OS
RyanCommits Jan 27, 2026
c4989d2
update default
RyanCommits Jan 27, 2026
831cbb2
add warning
RyanCommits Feb 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/FSPage.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,11 @@ const FullStory = isTurboModuleEnabled
? require('./NativeFullStory').default
: NativeModules.FullStory;

const { startPage, endPage, updatePage } = FullStory;
const { startPage, endPage, updatePage } = FullStory || {
startPage: () => null,
endPage: () => null,
updatePage: () => null,
};

type UnknownObj = {
[key: string]: unknown | UnknownObj;
Expand Down
23 changes: 20 additions & 3 deletions src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,10 @@ const FullStory = isTurboModuleEnabled
? require('./NativeFullStory').default
: NativeModules.FullStory;

if (!FullStory) {
console.warn('FullStory: Native module not found. Falling back to stub implementations.');
}

const {
anonymize,
identify,
Expand All @@ -31,7 +35,20 @@ const {
restart,
log,
resetIdleTimer,
} = FullStory;
} = FullStory || {
anonymize: () => null,
identify: () => null,
setUserVars: () => null,
onReady: () => Promise.resolve({ replayStartUrl: '', replayNowUrl: '', sessionId: '' }),
getCurrentSession: () => Promise.resolve(''),
getCurrentSessionURL: () => Promise.resolve(''),
consent: () => null,
event: () => null,
shutdown: () => null,
restart: () => null,
log: () => null,
resetIdleTimer: () => null,
};

const FullStoryPrivate = isTurboModuleEnabled
? require('./NativeFullStoryPrivate').default
Expand Down Expand Up @@ -60,7 +77,7 @@ interface NativeCommands {
dataComponent: (viewRef: ComponentRef<FSComponentType>, dataElement: string) => void;
}

/*
/*
Calling these commands sequentially will *not* lead to an intermediate state where views
have incomplete attribute values. React's rendering phases protects against this race condition.
See DOC-1863 for more information.
Expand Down Expand Up @@ -98,7 +115,7 @@ type FSNativeElement = ComponentRef<FSComponentType> & {

// Shared wrapper for components without refs (most common case)
function sharedRefWrapper(element: FSNativeElement | null) {
if (element && isTurboModuleEnabled && Platform.OS === 'ios') {
if (element && isTurboModuleEnabled && Platform.OS === 'ios' && !Platform.isTV) {
Copy link
Contributor

@martin-fs martin-fs Feb 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tvOS shouldn't be iOS (Apple treats them as separate platforms), but I guess it is because the issue implies that it is.

let currentProps: Record<keyof NativeCommands, string | object>;

if (getInternalInstanceHandleFromPublicInstance) {
Expand Down