Provide defaults if Fullstory module doesn't exist#143
Open
RyanCommits wants to merge 2 commits intomasterfrom
Open
Provide defaults if Fullstory module doesn't exist#143RyanCommits wants to merge 2 commits intomasterfrom
RyanCommits wants to merge 2 commits intomasterfrom
Conversation
martin-fs
approved these changes
Feb 4, 2026
Contributor
martin-fs
left a comment
martin-fs
left a comment
There was a problem hiding this comment.
Is there a way to add a warning log if we fall back to the stubs? Probably not needed but just in case something triggers that fallback by accident.
| // Shared wrapper for components without refs (most common case) | ||
| function sharedRefWrapper(element: FSNativeElement | null) { | ||
| if (element && isTurboModuleEnabled && Platform.OS === 'ios') { | ||
| if (element && isTurboModuleEnabled && Platform.OS === 'ios' && !Platform.isTV) { |
Contributor
There was a problem hiding this comment.
tvOS shouldn't be iOS (Apple treats them as separate platforms), but I guess it is because the issue implies that it is.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
VAL-9938
Fullstory React Native methods will not be available on iOS TV so we'll need to provide defaults.