Skip to content

Removed lodash dependancy#175

Open
OlegKonyk wants to merge 2 commits intog00fy-:masterfrom
OlegKonyk:master
Open

Removed lodash dependancy#175
OlegKonyk wants to merge 2 commits intog00fy-:masterfrom
OlegKonyk:master

Conversation

@OlegKonyk
Copy link

@OlegKonyk OlegKonyk commented Oct 14, 2015

issue #174

@OlegKonyk OlegKonyk mentioned this pull request Oct 14, 2015
Open
@th0th
Copy link

th0th commented Oct 14, 2015

Should we delete lodash from dependencies list in bower.json?

@OlegKonyk
Copy link
Author

OlegKonyk commented Oct 14, 2015

sorry, missed that, we definitely should.
By the way I did not have chance to test that callback function (introduced in previous version) if it is working as expected...

@eralha
Copy link
Collaborator

eralha commented Oct 14, 2015

is this tested?

@OlegKonyk
Copy link
Author

OlegKonyk commented Oct 14, 2015

Made some changes.
Tested. Callback works as expected.

@lcustodio
Copy link

lcustodio commented Oct 15, 2015

👍

Lodash is out since version v1.0.20

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@OlegKonyk @th0th @eralha @lcustodio