feat: introduce omit, extend, and safeExtend methods to CoMapSchema#3497
Merged
gdorsi merged 2 commits intogarden-co:mainfrom Mar 23, 2026
Merged
feat: introduce omit, extend, and safeExtend methods to CoMapSchema#3497gdorsi merged 2 commits intogarden-co:mainfrom
omit, extend, and safeExtend methods to CoMapSchema#3497gdorsi merged 2 commits intogarden-co:mainfrom
Conversation
…s to CoMapSchema
|
You have used all of your free Bugbot PR reviews. To receive reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial. |
|
@Gabrola is attempting to deploy a commit to the Garden Computing Team on Vercel. A member of the Team first needs to authorize it. |
gdorsi
approved these changes
Mar 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've refactored the existing
partial()andpick()methods to use the existing privatecopy()method and added some options to make sure they function exactly the same as before, which is not inheriting migrations, permissions,resolveQuery, andcatchallforpick().In my opinion though, all these derived schemas should inherit
permissions, andpartial()should also technically be able to inherit theresolveQueryjust based on the average user's expectation of behavior if they chain calls like thisschema.withPermissions(...).partial().I didn't want to introduce any behavioral changes to existing methods — especially inheriting permissions, this could potentially be a breaking change for some users, but I think making
partial()inheritresolveQueryshould be mostly fine though.Closes #2288