-
Notifications
You must be signed in to change notification settings - Fork 1
Enable lz4, lz4hc and zstd compression support for zram for kernel 6.6 #68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: rel-1592
Are you sure you want to change the base?
Conversation
@gehoern , can you please review and confirm if this change should be also in 6.6 (therefore 1443 and 1592 upcoming patches) or only in the 17 release? |
my 2 cents:
|
@nkraetzschmar fyi, this is the pr for 6.6., on main for 6.12 it is already merged with the same default. No one objected to that before, if you would like to change this before we release a new version, please put that forward. |
b5cb28f
to
7d051e7
Compare
CONFIG_ZRAM_BACKEND_LZ4=y | ||
CONFIG_ZRAM_BACKEND_LZ4HC=y | ||
CONFIG_ZRAM_BACKEND_ZSTD=y | ||
CONFIG_ZRAM_BACKEND_LZO=y |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Those are not defined in Linux 6.6.79
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hm, I thought I checked this, but maybe I made a mistake there.
Thanks for pointing that out.
Shall we close the PR, or is there a sensible replacement for those configs?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In linux 6.6 the crypto submodule provides an interface to the compression algorithms defined in lib, e.g lib/lz4.
In 6.6 we have a chain:
- CONFIG_ZRAM depends on CRYPTO_LZO which selects CONFIG_LZO_COMPRESS
- other compression/decompression functions are cascaded similarly with kconfig
Will check tomorrow what we need to enable in our configs
The interface changed in later kernel versions to a dedicated ZRAM compression backend with this patch series
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For the non-cloud kernel we have
CONFIG_ZRAM=m
CONFIG_CRYPTO_LZO=m
CONFIG_CRYPTO_LZ4=m
CONFIG_CRYPTO_LZ4HC=m
CONFIG_CRYPTO_ZSTD=m
(see here)
So it should be possible with 6.6, also according to the linked issue and the mentioned debian bug report (since we do not automatically pull in Debian's kernel config, but explicitly define all configs in our source tree, I double checked)
Starting with kernel 6.12 ZSTD compression is no longer available for ZRAM.
It used to be available by default.
So I would agree with closing this PR for now
What this PR does / why we need it:
Back porting #67 for the 6.6 line
Which issue(s) this PR fixes:
Fixes #66