Skip to content

feat(slices): add in-memory caching for slice content and stitched output #39335

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat(slices): add in-memory caching for slice content and stitched output #39335

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 23 additions & 8 deletions packages/gatsby/src/utils/slices/stitching.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,9 @@ interface ISliceBoundaryMatch {
type: "start" | "end"
}

const sliceCache = new Map<string, string>()
const stitchedSliceCache = new Map<string, string>()

function ensureExpectedType(maybeType: string): "start" | "end" {
if (maybeType === `start` || maybeType === `end`) {
return maybeType
Expand All @@ -28,10 +31,25 @@ async function stitchSlices(
let cursor = 0

async function getSliceContent(sliceHtmlName: string): Promise<string> {
return fs.readFile(
path.join(publicDir, `_gatsby`, `slices`, `${sliceHtmlName}.html`),
`utf-8`
)
if (!sliceCache.has(sliceHtmlName)) {
const content = await fs.readFile(
path.join(publicDir, `_gatsby`, `slices`, `${sliceHtmlName}.html`),
`utf-8`
)
sliceCache.set(sliceHtmlName, content)
}
return sliceCache.get(sliceHtmlName)!
}

async function getStitchedSlice(sliceHtmlName: string): Promise<string> {
if (!stitchedSliceCache.has(sliceHtmlName)) {
const stitched = await stitchSlices(
await getSliceContent(sliceHtmlName),
publicDir
)
stitchedSliceCache.set(sliceHtmlName, stitched)
}
return stitchedSliceCache.get(sliceHtmlName)!
}

for (const match of htmlString.matchAll(
Expand Down Expand Up @@ -100,10 +118,7 @@ async function stitchSlices(
continue
}

processedHTML += `${await stitchSlices(
await getSliceContent(meta.id),
publicDir
)}<!-- slice-end id="${meta.id}" -->`
processedHTML += `${await getStitchedSlice(meta.id)}<!-- slice-end id="${meta.id}" -->`
cursor = meta.end

previousStart = undefined
Expand Down