Skip to content

Conversation

@Amronos
Copy link
Contributor

@Amronos Amronos commented Oct 20, 2024

🦟 Bug fix

Summary

Updated link to ROS documentation for composition in ros2_overview.md.
Updated ros2_integration.md to add info about the new create_own_container argument.
Updated ros2_launch_gazebo.md to add documentation for gazebosim/ros_gz#620 and to add documentation for launching gazebo with ros_gz_bridge.
Changed the launch file used in ros2_spawn_model.md to gz_spawn_model.py instead of ros_gz_spawn_model.py. Added info about spawning a model alongside launching a bridge.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@Amronos Amronos requested a review from mabelzhang as a code owner October 20, 2024 06:37
@github-actions github-actions bot added the 🎵 harmonic Gazebo Harmonic label Oct 20, 2024
@Amronos Amronos force-pushed the composition-and-bridge-updates branch from 8bde312 to cc6d850 Compare October 25, 2024 14:18
@azeey azeey requested a review from caguero October 28, 2024 17:00
Copy link
Contributor

@caguero caguero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are great updates!

@azeey azeey merged commit 4f93d11 into gazebosim:master Oct 28, 2024
5 checks passed
@Amronos Amronos deleted the composition-and-bridge-updates branch October 29, 2024 01:50
azeey pushed a commit to azeey/docs that referenced this pull request Jan 9, 2025
* Composition and Bridge Updates

Signed-off-by: Aarav Gupta <[email protected]>

* Update composition_options.png

Signed-off-by: Aarav Gupta <[email protected]>

* Add documentation for spawning a model alongside launch ros_gz_bridge

Signed-off-by: Aarav Gupta <[email protected]>

* Undo changes made to comopsition_options.png

Has been done in gazebosim#531

Signed-off-by: Aarav Gupta <[email protected]>

---------

Signed-off-by: Aarav Gupta <[email protected]>
Signed-off-by: Aarav Gupta <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🎵 harmonic Gazebo Harmonic

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants