More spec fixes #511
Merged
More spec fixes #511
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ignacio Hagopian <[email protected]>
Signed-off-by: Ignacio Hagopian <[email protected]>
jsign
commented
Oct 16, 2024
Comment on lines
+355
to
+356
| isSystemContract := interpreter.evm.isSystemContract(address) | ||
| if _, isPrecompile := interpreter.evm.precompile(address); isPrecompile || isSystemContract { |
Signed-off-by: Ignacio Hagopian <[email protected]>
jsign
commented
Oct 16, 2024
Comment on lines
-410
to
+412
| if _, isPrecompile := interpreter.evm.precompile(addr); isPrecompile { | ||
| isSystemContract := interpreter.evm.isSystemContract(addr) | ||
| if _, isPrecompile := interpreter.evm.precompile(addr); isPrecompile || isSystemContract { |
gballet
requested changes
Oct 16, 2024
gballet
approved these changes
Oct 16, 2024
jsign
force-pushed
the
jsign-more-fixes
branch
from
b13fafc to
4bdfaba
Compare
Signed-off-by: Ignacio Hagopian <[email protected]>
jsign
force-pushed
the
jsign-more-fixes
branch
from
4bdfaba to
fa1e494
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is solving spec bugs found when @tanishqjasoria is running tentative v0.0.5 fixture set.