changing print to logging and minor logging fixes#14
Open
gayalkuruppu wants to merge 10 commits intogcucurull:masterfrom
Open
changing print to logging and minor logging fixes#14gayalkuruppu wants to merge 10 commits intogcucurull:masterfrom
gayalkuruppu wants to merge 10 commits intogcucurull:masterfrom
Conversation
When using this file (running the process_polyvore.sh) in cloud it is better to use nohup command. For that I added logging instead of print
changed print to logging
When using this file (running the process_polyvore.sh) in cloud it is better to use nohup command. For that I added logging instead of print
added logging instead of print
When training in the cloud ssh might broke, so it is always better to use nohup command. So I added logging instead of print, to log those print statements.
Added logging for train.py
logging error for dictionary fixed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have changed all the print statements to logging, for it to be able to run using nohup command. I have also changed some existing logging.info() lines which have given tuples where logging.info() expects strings in python 3.