Merged
Conversation
CB-quakemodel
approved these changes
Mar 2, 2026
Contributor
CB-quakemodel
left a comment
CB-quakemodel
left a comment
There was a problem hiding this comment.
Hi @nc-hsu, thanks for this PR. Apart from my one trivial comment it looks good to me.
| def setUp(self): | ||
| self.corr_model = ClemettCorrelationModelVrancea(np.array([1, 1.1, 2.0])) | ||
|
|
||
| # TODO |
Contributor
There was a problem hiding this comment.
Please remove this comment or expand what is still to be done here
Contributor
Author
There was a problem hiding this comment.
This is an erroneous comment that I forgot to delete. I have removed it now
micheles
approved these changes
Mar 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change allows the PGA to be considered in the calculation of AvgSA.
It is assumed that the same GMPE used to calculate the SA values can also be used to calculate the PGA.
Empirical correlation models, such as
ClemettCorrelationModelAscetc. will work with PGA so long as they have been defined for a period of T = 0.0s. Otherwise and error will be raised saying the period is out of range.