-
Notifications
You must be signed in to change notification settings - Fork 28
feat: add unionfield when multiple types are given #1279
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
WalkthroughA new Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant ContractParams.vue
participant useInputMap.ts
participant UnionField.vue
User->>ContractParams.vue: Interacts with contract parameter input
ContractParams.vue->>useInputMap.ts: getComponent(paramType)
useInputMap.ts-->>ContractParams.vue: Returns UnionField if union type
ContractParams.vue->>UnionField.vue: Renders with :unionTypes and modelValue
UnionField.vue->>ContractParams.vue: Emits update:modelValue on change
ContractParams.vue->>ContractParams.vue: Updates args accordingly
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~18 minutes Poem
Note ⚡️ Unit Test Generation is now available in beta!Learn more here, or try it out under "Finishing Touches" below. 📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (2)
🚧 Files skipped from review as they are similar to previous changes (2)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (5)
✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
|


Fixes DXP-546
What
UnionField.vuecomponent to handle multiple types in form inputs e.g.str | intgives two fields.ContractParams.vueto use the newUnionFieldcomponent for handling union types.useInputMap.tsto include logic for determining union types and returning the appropriate component.Why
To add a missing part where the user states multiple types.
Testing done
Test in a local studio by write a contract with init and write methods containing multiple types.
Decisions made
str | int, we do not know if the user wants to send 42 integer value or "42" string value so a smart type converter is not an option.list | dictthen we do not need two input boxes.Checks
Reviewing tips
UnionField.vuecomponent and its integration intoContractParams.vue.useInputMap.tsfor handling union types and ensure it aligns with the intended functionality.User facing release notes
Added frontend support for multiple argument types.
Summary by CodeRabbit
New Features
Improvements