PR for #329 optional basic auth disable #330
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomkralidis
approved these changes
Sep 1, 2020
Member
Author
|
Ok, thanks @tomkralidis for quick response! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce the GHC config var
GHC_BASIC_AUTH_DISABLEDwith default ofFalse(Basic Auth being enabled).Whenever there is an external Basic Auth active this can be set to False. This does not mean that the GHC User is automatically authorized, but mainly to disable Basic Auth checking. Normal UI-based Login will still work and is always in force. Later with e.g. API Token Auth we may still have GHC-specific authorization.