Explicitly add jinja2 dependency #1031
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was implicitly pulled in by Flask previously, but is actually required directly by pycsw so it should be explicitly mentioned in requirements
craigds
force-pushed
the
fix-jinja2-import
branch
from
1e9acc5 to
a8cc0f0
Compare
craigds
changed the title
pvgenuchten
approved these changes
Feb 6, 2025
Contributor
Author
|
can someone with merge rights hit the merge button please? |
Member
|
I would avoid adding dependencies if not directly needed. |
Contributor
|
Why is it not needed @kalxas? In case pycsw is used without html output support? |
Contributor
Author
|
pycsw literally imports this library, thus the dependency is clearly needed. Can someone please hit the merge button, it's crazy that this is just sitting around for almost a year |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Fixes an error importing pycswAssuming you install the requirements from
requirements-standalone.txtthis was already implicitly pulled in, but this PR makes the dependency explicitRelated Issue / Discussion
Fixes #1030
Additional Information
Contributions and Licensing
(as per https://github.com/geopython/pycsw/blob/master/CONTRIBUTING.rst#contributions-and-licensing)