Open
Conversation
Owner
|
Hello @peguerosdc and huge thank you for your contribution. Also, thank you for being transparent about the usage of chatGPT. I tested some random samples and they seem to be correct. So lets assume this is fine :) You seem to need this deployed as soon as possible, so I have to apologize for the late reply. I am going to work on a new release in the next couple of days and I hope this is helping. |
Owner
|
So after checking I came to the conclusion that it might be a bad idea to manually edit the automatically imported data. In fact, we pull in whatever gets delivered by the CLDR dataset. The next time we are going to update the data, de-DE will be removed again. I am going to think about a solution. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is related to georgkrause/langcodes#35 which I realized can be solved by opening a PR in this library. I leave the specific line I added in here to make it easier to review:
Most of the names were written by ChatGPT so I hope they are correct, but If you have a standard verification process please let me know.
Also, please let me know if I am missing something to bump the version and get this deployed.