Open
Conversation
# Conflicts: # Classes/Domain/Model/Client.php # Classes/Service/Import/ClientImport.php # Configuration/TCA/tx_t3monitoring_domain_model_client.php # ext_tables.sql
Collaborator
|
@beathorst Hi Janek! Are you motivated to update you PR? Since your PR some updates were done in t3monitoring like basicauth. |
Collaborator
|
Whats the benefit of this PR? |
1 similar comment
Collaborator
|
Whats the benefit of this PR? |
Author
Long time ago... it is for have all be users at one place to check if there is a user which is not longer in the company |
Collaborator
|
Ah okay. I'm going to resolve it with my PR "add Checks" to Bring Back the old Caretaker Checks where you ask the Client If there are some unwanted Users, Extensions or configuration directives. I will try to use your Code and transfer only unwanted Users :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I merge the PR #50 and fixed the conflicts, for me it is a very nice feature. it would be nice to have it in the ext