Fix permissions on /tmp #250
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Nice catch. Thank you. Maybe we should just change the cleanup line to |
When cleaning up, delete the contents of /tmp, but not /tmp itself.
Author
|
Thanks for the suggestion. That was the other option I considered, but I figured it wouldn't catch any dot-files/directories. Probably not a huge concern, though, so I've adjusted the PR and rebased on the latest from |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When cleaning up, delete the contents of /tmp, but not /tmp itself.
Previously, the image ended up with /tmp having permission bits 0755. This caused issues with JMX when running as an unprivileged user: the user didn't have permission to create its hsperfdata directory under /tmp.