[fix-escape] Auto-translate missing keys in locales #1356
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=80&v=4){kind=small}
- Add EncodeSubject function to properly encode non-ASCII characters in email subject headers - Use Go's built-in mime.QEncoding which implements RFC 2047 quoted-printable encoding - Apply encoding in all email services: SMTP, Mailgun, and AWS SES - ASCII-only subjects remain unencoded for compatibility - Add comprehensive tests for the encoding function This fixes issues with non-ASCII characters (umlauts, accents, emojis) in email subjects that were previously displayed incorrectly in some email clients and servers. Resolves compatibility issues with downstream SMTP servers that don't support SMTPUTF8. Fixes #1147
Fixed stacking up of escape handlers.
An error occurred while trying to automatically change base from
fix-escape
to
main
August 19, 2025 20:41
fix: encode email subject headers according to RFC 2047
…fider into markdown-image-support
Added support for URL based images.
github-actions
bot
force-pushed
the
auto/translate-missing-keys
branch
from
a7f313b to
d284c3c
Compare
…nto github-homepage
GitHub homepage
github-actions
bot
force-pushed
the
auto/translate-missing-keys
branch
from
d284c3c to
323110b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds machine-translated values for any missing locale keys.