Decouple build steps to be more flexible #446
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sschulz92
force-pushed
the
DECOUPLE_INSTALL_AND_TESTS
branch
from
786359f to
f3e4dd7
Compare
Signed-off-by: sschulz92 <[email protected]>
sschulz92
force-pushed
the
DECOUPLE_INSTALL_AND_TESTS
branch
from
f3e4dd7 to
3f74933
Compare
|
Can you please add summaries to your PR to explain what you're trying to achieve? Why is the flexibility needed? What have you tested/considered? Etc. |
Good hint, just updated the description! |
chadlwilson
approved these changes
Sep 1, 2025
|
LGTM thx! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of this PR I would like to decouple the execution of tests and the local installation of the plugin. In one of my Pull-Requests I wanted to have a quick feedback if the changes are OK without the installation as I was not done yet. To allow users customized options, they are simply decoupled. Install without running tests? No issue.
❌
python build.py --test --installwas not installing anything before my change💹
python build.py --test --installis running the tests and installs gauge-python afterwardsOn top, if you have test failures, the coverage file was not created as part of the
coverage run ...command, so that the lineos.rename(".coverage", f".coverage.{i}")failed: no file available to rename --> FileNotFoundError exception. To overcome this behaviour, I am using the exit-code information to break the look immediately.