Fix typo and use unit test builtins #447
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: sschulz92 <[email protected]>
sschulz92
force-pushed
the
FIX_SCREENSHOT_TYPO
branch
from
7558a34 to
a02cf87
Compare
|
@chadlwilson While investigating the test failure in my first PR, I identified the issue: gauge-proto Mind having a look? 😄 |
|
It's probably best not to conflate unrelated changes in one PR anyway,.especially if that PR has a specific goal focused in a single area. It makes it more difficult to review any logical change and may be more likely to end up with conflicts with other changes. |
chadlwilson
approved these changes
Sep 1, 2025
|
I updated the protos (and re-generated) at #448 and they seem OK? Try merging/rebasing off master on one of your branches :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.