fix(kratos-cli): update module and moduleResolution #148
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR updates the module settings for the kratos-cli package by removing deprecated properties from the library configuration and switching to modern Node ESM options in the main configuration.
- Removed "module": "Preserve" and "moduleResolution": "bundler" from tsconfig.lib.json.
- Changed "module" from "commonjs" to "nodenext" and added "moduleResolution": "nodenext" in tsconfig.json.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/kratos-cli/tsconfig.lib.json | Removed outdated module settings to streamline library build configuration. |
| packages/kratos-cli/tsconfig.json | Updated module settings to use the modern nodenext option for ESM support. |
Comments suppressed due to low confidence (2)
packages/kratos-cli/tsconfig.lib.json:5
- Removing explicit module and moduleResolution settings may cause differences in how modules are processed between the library and application builds; verify that this change aligns with the intended build strategy.
"module": "Preserve",
packages/kratos-cli/tsconfig.json:4
- The switch from 'commonjs' to 'nodenext' improves compatibility with modern Node ESM features; ensure that all parts of the codebase and dependencies are ready to support this configuration.
"module": "nodenext",
|
View your CI Pipeline Execution ↗ for commit 9af64fc.
☁️ Nx Cloud last updated this comment at |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.