feat: prevent duplicate action name #879
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WalkthroughAdded a duplicate-name validation feature to InterpretationLog by introducing a Changes
Sequence DiagramsequenceDiagram
actor User
participant InterpretationLog
participant checkForDuplicateName
participant useGlobalInfoStore
User->>InterpretationLog: Attempt to save/edit step with new name
InterpretationLog->>checkForDuplicateName: checkForDuplicateName(stepId, type, newName)
alt Duplicate Found
checkForDuplicateName->>useGlobalInfoStore: notify(error message)
useGlobalInfoStore-->>InterpretationLog: Error emitted
InterpretationLog-->>User: Update aborted
else No Duplicate
checkForDuplicateName-->>InterpretationLog: Validation passed
InterpretationLog->>InterpretationLog: Apply edits
InterpretationLog-->>User: Update successful
end
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes
Possibly related PRs
Suggested labels
Suggested reviewers
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
src/components/run/InterpretationLog.tsx(3 hunks)
🧰 Additional context used
🧬 Code graph analysis (1)
src/components/run/InterpretationLog.tsx (1)
src/context/globalInfo.tsx (1)
useGlobalInfoStore(186-186)
Comment on lines
+157
to
+177
| const checkForDuplicateName = (stepId: number, type: 'list' | 'text' | 'screenshot', newName: string): boolean => { | ||
| const trimmedName = newName.trim(); | ||
|
|
||
| if (type === 'list') { | ||
| const listSteps = browserSteps.filter(step => step.type === 'list' && step.id !== stepId); | ||
| const duplicate = listSteps.find(step => step.name === trimmedName); | ||
| if (duplicate) { | ||
| notify('error', `A list with the name "${trimmedName}" already exists. Please choose a different name.`); | ||
| return true; | ||
| } | ||
| } else if (type === 'screenshot') { | ||
| const screenshotSteps = browserSteps.filter(step => step.type === 'screenshot' && step.id !== stepId); | ||
| const duplicate = screenshotSteps.find(step => step.name === trimmedName); | ||
| if (duplicate) { | ||
| notify('error', `A screenshot with the name "${trimmedName}" already exists. Please choose a different name.`); | ||
| return true; | ||
| } | ||
| } | ||
|
|
||
| return false; | ||
| }; |
There was a problem hiding this comment.
Handle duplicate text labels too
checkForDuplicateName short-circuits only for lists and screenshots. When editing a text step, it always falls through and returns false, so two text captures can still share the same label—failing the “unique per capture action type” requirement and the helper’s own 'text' signature. Add a text-specific guard before returning.
} else if (type === 'screenshot') {
const screenshotSteps = browserSteps.filter(step => step.type === 'screenshot' && step.id !== stepId);
const duplicate = screenshotSteps.find(step => step.name === trimmedName);
if (duplicate) {
notify('error', `A screenshot with the name "${trimmedName}" already exists. Please choose a different name.`);
return true;
}
+ } else if (type === 'text') {
+ const textSteps = browserSteps.filter(step => step.type === 'text' && step.id !== stepId);
+ const duplicate = textSteps.find(step => step.label?.trim() === trimmedName);
+ if (duplicate) {
+ notify('error', `A text entry with the name "${trimmedName}" already exists. Please choose a different name.`);
+ return true;
+ }
}📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
Suggested change
| const checkForDuplicateName = (stepId: number, type: 'list' | 'text' | 'screenshot', newName: string): boolean => { | |
| const trimmedName = newName.trim(); | |
| if (type === 'list') { | |
| const listSteps = browserSteps.filter(step => step.type === 'list' && step.id !== stepId); | |
| const duplicate = listSteps.find(step => step.name === trimmedName); | |
| if (duplicate) { | |
| notify('error', `A list with the name "${trimmedName}" already exists. Please choose a different name.`); | |
| return true; | |
| } | |
| } else if (type === 'screenshot') { | |
| const screenshotSteps = browserSteps.filter(step => step.type === 'screenshot' && step.id !== stepId); | |
| const duplicate = screenshotSteps.find(step => step.name === trimmedName); | |
| if (duplicate) { | |
| notify('error', `A screenshot with the name "${trimmedName}" already exists. Please choose a different name.`); | |
| return true; | |
| } | |
| } | |
| return false; | |
| }; | |
| const checkForDuplicateName = (stepId: number, type: 'list' | 'text' | 'screenshot', newName: string): boolean => { | |
| const trimmedName = newName.trim(); | |
| if (type === 'list') { | |
| const listSteps = browserSteps.filter(step => step.type === 'list' && step.id !== stepId); | |
| const duplicate = listSteps.find(step => step.name === trimmedName); | |
| if (duplicate) { | |
| notify('error', `A list with the name "${trimmedName}" already exists. Please choose a different name.`); | |
| return true; | |
| } | |
| } else if (type === 'screenshot') { | |
| const screenshotSteps = browserSteps.filter(step => step.type === 'screenshot' && step.id !== stepId); | |
| const duplicate = screenshotSteps.find(step => step.name === trimmedName); | |
| if (duplicate) { | |
| notify('error', `A screenshot with the name "${trimmedName}" already exists. Please choose a different name.`); | |
| return true; | |
| } | |
| } else if (type === 'text') { | |
| const textSteps = browserSteps.filter(step => step.type === 'text' && step.id !== stepId); | |
| const duplicate = textSteps.find(step => step.label?.trim() === trimmedName); | |
| if (duplicate) { | |
| notify('error', `A text entry with the name "${trimmedName}" already exists. Please choose a different name.`); | |
| return true; | |
| } | |
| } | |
| return false; | |
| }; |
🤖 Prompt for AI Agents
In src/components/run/InterpretationLog.tsx around lines 157 to 177, the
duplicate-name check only handles 'list' and 'screenshot' so 'text' edits can
create non-unique labels; add a branch for type === 'text' that filters
browserSteps for type 'text' excluding the current stepId, checks for an
existing step with the same trimmed name, calls notify('error', `A text capture
with the name "${trimmedName}" already exists. Please choose a different name.`)
if found, and returns true; keep the existing return false at the end.
amhsirak
approved these changes
Nov 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does?
Adds a validity check to ensure unique names among each capture action type.
2025-11-07.14-17-34.mp4
Summary by CodeRabbit
Release Notes