-
Notifications
You must be signed in to change notification settings - Fork 19
feat(#560): edit coordinates for a vertex or feature #606
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
🦋 Changeset detectedLatest commit: bfaf87b The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
| mapFeatures?.saveFeature(feature); | ||
| // Refresh selected vertex. | ||
| const vertexIndex = feature.get(SELECTED_VERTEX_INDEX_PROPERTY) as number | undefined; | ||
| events.onVertexSelect(getVertexByIndex(feature, vertexIndex)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This refresh updates the status bar and the advanced panel after a vertex is deleted or updated.
|
Testing finished and recorded evidence |
…vertex # Conflicts: # packages/web-forms/tests/components/common/map/createFeatureCollectionAndProps.test.ts
Closes #560
WIP
Questions:
I have verified this PR works in these browsers (latest versions):
What else has been done to verify that this works as intended?
Test case: placement-map
placement-map.mp4
Test case: trace
trace.mp4
Test case: shape
shape.mp4
Test case: Status bar message
save.message.mp4
Why is this the best possible solution? Were any other approaches considered?
This is an extension of the current feature:
How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?
Do we need any specific form for testing your changes? If so, please attach one.
What's changed
mapHelpers.tsto perform basic validation and return coordinates based on whether the expected feature is a point, line string, or polygon. This is used to return the correct coordinate format after the user pastes a value or uploads a file to overwrite an existing feature.createFeatureCollectionAndProps.tsto geojson-parsers.tsgeojson-parsers.ts