Skip to content

Conversation

@trevor-e
Copy link
Member

@trevor-e trevor-e commented Jul 24, 2025

  • Fixes bug where Watch/AppExtension binaries weren't considered for the export metadata insight
  • Fixes the duplicate files insight to group the results by file, previously everything was flat. Also fixes some edge cases where it would report duplicates within nested folders.
    • Added special grouping for .bundle folders and allowlisted .xcprivacy files
  • Introduces a new FileSavingsResult to share amongst insights which is more slimmed down and should make the response JSON smaller.

@codecov
Copy link

codecov bot commented Jul 24, 2025

Codecov Report

Attention: Patch coverage is 89.91935% with 50 lines in your changes missing coverage. Please review.

Project coverage is 76.05%. Comparing base (3f0cb9b) to head (cd4c23d).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
src/launchpad/size/utils/file_analysis.py 83.19% 17 Missing and 3 partials ⚠️
src/launchpad/artifacts/apple/zipped_xcarchive.py 5.55% 16 Missing and 1 partial ⚠️
.../launchpad/size/insights/common/duplicate_files.py 83.58% 5 Missing and 6 partials ⚠️
src/launchpad/size/models/common.py 83.33% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #216      +/-   ##
==========================================
+ Coverage   75.78%   76.05%   +0.27%     
==========================================
  Files         127      129       +2     
  Lines        9961    10204     +243     
  Branches     1124     1147      +23     
==========================================
+ Hits         7549     7761     +212     
- Misses       2010     2037      +27     
- Partials      402      406       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@trevor-e trevor-e merged commit 0472759 into main Jul 24, 2025
20 checks passed
@trevor-e trevor-e deleted the telkins/fix-insights-2 branch July 24, 2025 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants