feat: Add signing expiration dates #219
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trevor-e
approved these changes
Jul 24, 2025
| earliest_expiration = expiration_date | ||
|
|
||
| except Exception as e: | ||
| logger.warning(f"Failed to parse certificate: {e}") |
There was a problem hiding this comment.
nit: can you make this an error log
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #219 +/- ##
==========================================
- Coverage 76.06% 76.06% -0.01%
==========================================
Files 129 129
Lines 10216 10248 +32
Branches 1148 1153 +5
==========================================
+ Hits 7771 7795 +24
- Misses 2038 2043 +5
- Partials 407 410 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
noahsmartin
force-pushed
the
addSigningExpirationDate
branch
from
34aa540 to
510d7cc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.