Skip to content

Conversation

chromy
Copy link
Contributor

@chromy chromy commented Oct 3, 2025

  • Moves Python deps into pyproject.toml
  • Adds and uses a lock file for Python deps (uv.lock)
  • Factors common setup steps for Github workflows into a new file
  • Updates devenv to install Python via uv / .python-version simplifying sync.py
  • Updates Dockerfile, Makefile, and github workflows to reflect the above.

This aligns us much closer with the new suggested setup for Python:
https://www.notion.so/sentry/Standard-Spec-python-uv-2248b10e4b5d8045b8fff30f8b8b67ca

Fixes EME-212
Prepares to fix EME-213

Copy link

linear bot commented Oct 10, 2025

@chromy chromy force-pushed the chromy/2025-10-03-use-uv branch 20 times, most recently from 523b041 to 1a9c82c Compare October 14, 2025 10:47
@getsentry getsentry deleted a comment from codecov bot Oct 14, 2025
@chromy chromy changed the title Use uv Create and use uv.lock Oct 14, 2025
@chromy chromy force-pushed the chromy/2025-10-03-use-uv branch from 1a9c82c to 83afe72 Compare October 14, 2025 10:57
"google-api-python-client==2.181.0",
"lief==0.16.6",
"lzfse>=0.4.2",
"pillow>=11.3.0",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we try locking everything to a specific version or should we do that in a follow-up step?

$(VENV_DIR)/bin/pre-commit install
# Python, uv, and Python requirements (core and dev) installed via
# the github workflow.
install-dev-for-ci:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: if this is CI-specific maybe just do it directly in the workflow? e.g. it's already calling uv sync --frozen --active and not using a makefile command for that, but don't have a strong opinion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants